Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get startTime outside the executor task to avoid flaky time checks #13250

Merged
merged 1 commit into from
May 28, 2024
Merged

get startTime outside the executor task to avoid flaky time checks #13250

merged 1 commit into from
May 28, 2024

Conversation

klsince
Copy link
Contributor

@klsince klsince commented May 28, 2024

fix flaky checks for test method testConsistencyModeSnapshot by recording the startMs outside the executor task.

@klsince klsince mentioned this pull request May 28, 2024
Closed
@Jackie-Jiang Jackie-Jiang merged commit fdfae5e into apache:master May 28, 2024
19 checks passed
@klsince klsince deleted the fix_flaky_time_check branch May 28, 2024 23:05
gortiz pushed a commit to gortiz/pinot that referenced this pull request Jun 14, 2024
@klsince @gortiz
get startTime outside the executor task to avoid flaky time checks (a…
5fdfe24 
…pache#13250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tibrewalpratik17 tibrewalpratik17 tibrewalpratik17 approved these changes

@Jackie-Jiang Jackie-Jiang Jackie-Jiang approved these changes

Assignees
No one assigned
Labels
bugfix flaky-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klsince @Jackie-Jiang @tibrewalpratik17